Skip to content

Conversation

@edenhaus
Copy link
Member

  • Deebot N30 (npu3pt)
  • Deebot N50 (kl54s5)
  • Deebot N50 Omni (36hdj8 and 6q3rfp)
  • Deebot X8 Pro Omni (gcu5tt and y72606)

Copilot AI review requested due to automatic review settings September 22, 2025 20:48
@edenhaus edenhaus added the pr: new-feature PR, which adds a new feature label Sep 22, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for new Deebot device models by creating hardware configuration files that reference existing device implementations through similarity mappings.

  • Adds 6 new device model files for Deebot N30, N50, N50 Omni, and X8 Pro Omni variants
  • Each new device file contains a single line referencing an existing device implementation
  • Uses device similarity approach to inherit behavior from compatible existing models

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
deebot_client/hardware/deebot/npu3pt.py Adds Deebot N30 device configuration referencing ruhc0q.py
deebot_client/hardware/deebot/kl54s5.py Adds Deebot N50 device configuration referencing viq3mw.py
deebot_client/hardware/deebot/36hdj8.py Adds Deebot N50 Omni device configuration referencing viq3mw.py
deebot_client/hardware/deebot/6q3rfp.py Adds Deebot N50 Omni device configuration referencing viq3mw.py
deebot_client/hardware/deebot/gcu5tt.py Adds Deebot X8 Pro Omni device configuration referencing n0vyif.py
deebot_client/hardware/deebot/y72606.py Adds Deebot X8 Pro Omni device configuration referencing n0vyif.py
Comments suppressed due to low confidence (3)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.95%. Comparing base (a250299) to head (1e81c9e).
⚠️ Report is 1 commits behind head on dev.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1179   +/-   ##
=======================================
  Coverage   93.95%   93.95%           
=======================================
  Files         136      136           
  Lines        5163     5163           
  Branches      336      336           
=======================================
  Hits         4851     4851           
  Misses        248      248           
  Partials       64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@edenhaus edenhaus merged commit 341c25c into dev Sep 22, 2025
25 checks passed
@edenhaus edenhaus deleted the similar-devices branch September 22, 2025 20:52
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 22, 2025

CodSpeed Performance Report

Merging #1179 will not alter performance

Comparing similar-devices (1e81c9e) with dev (a250299)

Summary

✅ 6 untouched

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: new-feature PR, which adds a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants