Skip to content

sync Github dap-main with Gitlab dap-main #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2024
Merged

sync Github dap-main with Gitlab dap-main #1

merged 1 commit into from
Oct 29, 2024

Conversation

@Magicbeanbuyer
Copy link

Summary

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

canbekley
canbekley approved these changes Oct 29, 2024
View reviewed changes
Copy link

@canbekley canbekley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Magicbeanbuyer Magicbeanbuyer merged commit 5c651c7 into dap-main Oct 29, 2024
@Magicbeanbuyer Magicbeanbuyer deleted the syc-github-with-gitlab-dap-main branch October 29, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@canbekley canbekley canbekley approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Magicbeanbuyer @canbekley