[Op] Canonicalize SaveV2 Op device spec in distributed training. #925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candyzone
reviewed
Aug 17, 2023
Collaborator
candyzone
left a comment
candyzone
left a comment
There was a problem hiding this comment.
try pull request to tensorflow.
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/training/saver.py#L420
tensorflow/python/training/saver.py
Outdated
| device_name = pydev.canonical_name(spec.tensor.device) | ||
| device_idx = device_name.find("/device") | ||
| if device_idx != -1: | ||
| canonical_device.add(device_name[:idx]) |
Contributor
Author
There was a problem hiding this comment.
Already updated.
Mesilenceki
force-pushed
the
fix/nums-of-saveops-inconsistent-with-device
branch
from
17ab349 to
c0ade86
Compare
candyzone
approved these changes
Nov 7, 2023
…d training. Signed-off-by: 泊霆 <hujunqi.hjq@alibaba-inc.com>
Mesilenceki
force-pushed
the
fix/nums-of-saveops-inconsistent-with-device
branch
from
c0ade86 to
c2b3500
Compare
candyzone
approved these changes
Nov 8, 2023
candyzone
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.