Avoid duplicate deployments for customized needed_services #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #353 Since (#344 and) #338 we re-use the `needed_services` dependency tree to order the deployments steps. This had an unexpected consequence: "duplicated" services via customization via `needed_services` also duplicated their deployment. Customized needed_services make in fact only sense for local execution as a dependency during `dmake shell/test/run`: it should *not* create new deployments. PR #334 + #338 changed the semantic of `dmake deploy`: deployment is now recursive. We still want that. This commit resolves all this by following on #338: - recurse at the deployment level - but strip service customization in recursion
maingoh
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #353
Since (#344 and) #338 we re-use the
needed_servicesdependency treeto order the deployments steps.
This had an unexpected consequence: "duplicated" services via
customization via
needed_servicesalso duplicated their deployment.Customized needed_services make in fact only sense for local execution
as a dependency during
dmake shell/test/run: it should not createnew deployments.
PR #334 + #338 changed the semantic of
dmake deploy: deployment isnow recursive. We still want that.
This commit resolves all this by following on #338: