Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix static and dynamic type finding #1050

Merged
merged 1 commit into from Jun 10, 2019

Conversation

@dr3dd589
Copy link
Member

dr3dd589 commented Apr 12, 2019

fix #990

  • Your code is flake8 compliant (DefectDojo's code isn't currently flake8 compliant, but we're trying to correct that.)
  • If this is a new feature and not a bug fix, you've included the proper documentation in the ReadTheDocs documentation folder. https://github.com/DefectDojo/Documentation/tree/master/docs or provide feature documentation in the PR.
  • Model changes should include the necessary migrations in the dojo/dd_migrations folder.
  • Add applicable tests to the unit tests.
@dr3dd589

This comment has been minimized.

Copy link
Member Author

dr3dd589 commented Apr 24, 2019

@adracea @valentijnscholten Can you please review this one! suggest me if there is any other way to do it.

@valentijnscholten

This comment has been minimized.

Copy link
Contributor

valentijnscholten commented Apr 24, 2019

I have no idea what the difference between static and dynamic is yet, so I'll have to leave it to the other reviewers.

Copy link
Contributor

adracea left a comment

@dr3dd589 It looks okay to me at first glance

@adracea adracea requested a review from aaronweaver Apr 24, 2019
@dr3dd589

This comment has been minimized.

Copy link
Member Author

dr3dd589 commented May 28, 2019

@aaronweaver Can you please review this one. thanks!

Copy link
Collaborator

Maffooch left a comment

Works as intended. Good job. See if possible to push into dev instead.

@dr3dd589 dr3dd589 changed the base branch from master to dev Jun 8, 2019
@dr3dd589

This comment has been minimized.

Copy link
Member Author

dr3dd589 commented Jun 8, 2019

done! @Maffooch thanks. didn't see that I pushed this PR into the master branch.

@Maffooch Maffooch merged commit 0d4b069 into DefectDojo:dev Jun 10, 2019
4 checks passed
4 checks passed
AccessLint Review complete
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - components/package.json (aaronweaver (GitHub marketplace)) No new issues
Details
security/snyk - requirements.txt (aaronweaver (GitHub marketplace)) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.