Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix product grading #1082

Merged
merged 1 commit into from Apr 25, 2019

Conversation

@dr3dd589
Copy link
Member

dr3dd589 commented Apr 24, 2019

fix #1034

I think there is no need for if statement on severity_values. because it returns none type when there are no active findings.

When submitting a pull request, please make sure you have completed the following checklist:

  • Your code is flake8 compliant (DefectDojo's code isn't currently flake8 compliant, but we're trying to correct that.)
  • If this is a new feature and not a bug fix, you've included the proper documentation in the ReadTheDocs documentation folder. https://github.com/DefectDojo/Documentation/tree/master/docs or provide feature documentation in the PR.
  • Model changes should include the necessary migrations in the dojo/dd_migrations folder.
  • Add applicable tests to the unit tests.
@aaronweaver aaronweaver merged commit d69413e into DefectDojo:dev Apr 25, 2019
4 checks passed
4 checks passed
AccessLint Review complete
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - components/package.json (aaronweaver (GitHub marketplace)) No manifest changes detected
security/snyk - requirements.txt (aaronweaver (GitHub marketplace)) No manifest changes detected
@dr3dd589 dr3dd589 deleted the dr3dd589:fix_product_grading branch Apr 26, 2019
@zfirered

This comment has been minimized.

Copy link

zfirered commented Oct 25, 2019

is there any fix fr this?
Because product grading doesn't show up anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.