Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product type Unit test #1153

Merged
merged 3 commits into from May 22, 2019

Conversation

@dr3dd589
Copy link
Member

dr3dd589 commented May 20, 2019

fix #1131
Implemented test for the following:-

  • Add product type

  • Edit product type

  • Delete product type

  • Your code is flake8 compliant (DefectDojo's code isn't currently flake8 compliant, but we're trying to correct that.)

  • If this is a new feature and not a bug fix, you've included the proper documentation in the ReadTheDocs documentation folder. https://github.com/DefectDojo/Documentation/tree/master/docs or provide feature documentation in the PR.

  • Model changes should include the necessary migrations in the dojo/dd_migrations folder.

  • Add applicable tests to the unit tests.

@devGregA devGregA requested review from Maffooch and aaronweaver May 20, 2019
tests/Product_type_unit_test.py Outdated Show resolved Hide resolved
tests/Product_type_unit_test.py Outdated Show resolved Hide resolved
tests/Product_type_unit_test.py Show resolved Hide resolved
@dr3dd589

This comment has been minimized.

Copy link
Member Author

dr3dd589 commented May 22, 2019

@Maffooch done. thanks!

@devGregA

This comment has been minimized.

Copy link
Collaborator

devGregA commented May 22, 2019

@Maffooch please confirm when it's good to merge.

@Maffooch

This comment has been minimized.

Copy link
Collaborator

Maffooch commented May 22, 2019

Confirmed to merge.

@devGregA devGregA merged commit ce53e8f into DefectDojo:dev May 22, 2019
4 checks passed
4 checks passed
AccessLint Review complete
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - components/package.json (aaronweaver (GitHub marketplace)) No manifest changes detected
security/snyk - requirements.txt (aaronweaver (GitHub marketplace)) No manifest changes detected
@devGregA

This comment has been minimized.

Copy link
Collaborator

devGregA commented May 22, 2019

Great stuff @dr3dd589 which one would you like next?

@dr3dd589

This comment has been minimized.

Copy link
Member Author

dr3dd589 commented May 23, 2019

start working on this #1133.

@dr3dd589 dr3dd589 deleted the dr3dd589:ProductTypeTest branch Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.