Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engagement unit test #1170

Merged
merged 8 commits into from May 28, 2019

Conversation

@dr3dd589
Copy link
Member

dr3dd589 commented May 23, 2019

fix #1133

implemented the following tests:

  • Add
  • Edit
  • Close
  • Delete
  • Import scan results
  • Add new CI/CD Engagement

When submitting a pull request, please make sure you have completed the following checklist:

  • Your code is flake8 compliant (DefectDojo's code isn't currently flake8 compliant, but we're trying to correct that.)
  • If this is a new feature and not a bug fix, you've included the proper documentation in the ReadTheDocs documentation folder. https://github.com/DefectDojo/Documentation/tree/master/docs or provide feature documentation in the PR.
  • Model changes should include the necessary migrations in the dojo/dd_migrations folder.
  • Add applicable tests to the unit tests.
@dr3dd589 dr3dd589 changed the title Engagement unit tests Engagement unit test May 23, 2019
tests/Engagement_unit_test.py Show resolved Hide resolved
tests/Engagement_unit_test.py Outdated Show resolved Hide resolved
tests/Engagement_unit_test.py Outdated Show resolved Hide resolved
@dr3dd589 dr3dd589 force-pushed the dr3dd589:EngagementUnitest branch from 5a9d359 to 1a35916 May 28, 2019
@dr3dd589

This comment has been minimized.

Copy link
Member Author

dr3dd589 commented May 28, 2019

@Maffooch done!

@Maffooch

This comment has been minimized.

Copy link
Collaborator

Maffooch commented May 28, 2019

@dr3dd589 Don't forget the delete product as well.

@dr3dd589

This comment has been minimized.

Copy link
Member Author

dr3dd589 commented May 28, 2019

ohh! sorry about that. :)

@Maffooch Maffooch requested a review from devGregA May 28, 2019
@devGregA devGregA merged commit e6c7337 into DefectDojo:dev May 28, 2019
4 checks passed
4 checks passed
AccessLint Review complete
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - components/package.json (aaronweaver (GitHub marketplace)) No manifest changes detected
security/snyk - requirements.txt (aaronweaver (GitHub marketplace)) No manifest changes detected
@dr3dd589 dr3dd589 deleted the dr3dd589:EngagementUnitest branch Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.