Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(helm): logLevel and resource.requests are set on wrong level #1199

Merged
merged 2 commits into from Jun 5, 2019

Conversation

@Miradorn
Copy link
Contributor

commented May 31, 2019

The logLevel is used only in the ConfigMap which is shared by the worker and beat.
Also the resource requests are missing a subkey.
With these changes the helm chart should be fully functioning.

When submitting a pull request, please make sure you have completed the following checklist:

  • Your code is flake8 compliant (DefectDojo's code isn't currently flake8 compliant, but we're trying to correct that.)
  • If this is a new feature and not a bug fix, you've included the proper documentation in the ReadTheDocs documentation folder. https://github.com/DefectDojo/Documentation/tree/master/docs or provide feature documentation in the PR.
  • Model changes should include the necessary migrations in the dojo/dd_migrations folder.
  • Add applicable tests to the unit tests.
The logLevel is used only in the ConfigMap which is shared by the worker and beat.
@aaronweaver aaronweaver requested a review from devGregA May 31, 2019
Add missing key for Resource Requests
@Miradorn Miradorn changed the title Fix(helm): logLevel is set on wrong level Fix(helm): logLevel and resource.requests are set on wrong level Jun 3, 2019
@devGregA devGregA merged commit aea1d60 into DefectDojo:dev Jun 5, 2019
4 checks passed
4 checks passed
AccessLint Review complete
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - components/package.json (aaronweaver (GitHub marketplace)) No manifest changes detected
security/snyk - requirements.txt (aaronweaver (GitHub marketplace)) No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.