Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sslyze Scan Importer #1376

Merged
merged 5 commits into from Jul 15, 2019

Conversation

@dr3dd589
Copy link
Member

dr3dd589 commented Jul 13, 2019

fix #1140

Note: DefectDojo is now on Python3 and Django 2.2.1 Please submit your pull requests to the 'dev' branch as the 'legacy-python2.7' branch is only for bug fixes. Any new features submitted to the legacy branch will be ignored and closed.

When submitting a pull request, please make sure you have completed the following checklist:

  • Your code is flake8 compliant
  • If this is a new feature and not a bug fix, you've included the proper documentation in the ReadTheDocs documentation folder. https://github.com/DefectDojo/Documentation/tree/master/docs or provide feature documentation in the PR.
  • Model changes must include the necessary migrations in the dojo/dd_migrations folder.
  • Add applicable tests to the unit tests.
@dr3dd589

This comment has been minimized.

Copy link
Member Author

dr3dd589 commented Jul 13, 2019

hello, @Maffooch you said not to add sample file here, but that's why tests are failing. how to connect sample-scans-files repo to this to ensure that tests are working correctly?

@NRGLine4Sec

This comment has been minimized.

Copy link

NRGLine4Sec commented Jul 14, 2019

nice !! Good Job !

@Maffooch

This comment has been minimized.

Copy link
Collaborator

Maffooch commented Jul 15, 2019

@dr3dd589 Put the sample files in both places.

Copy link
Collaborator

Maffooch left a comment

Looks fine. Good job.

@devGregA devGregA merged commit 5e2f3a4 into DefectDojo:dev Jul 15, 2019
4 checks passed
4 checks passed
AccessLint Review complete
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - components/package.json (aaronweaver (GitHub marketplace)) No manifest changes detected
security/snyk - requirements.txt (aaronweaver (GitHub marketplace)) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.