Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Veracode fix static and dynamic issue #1377

Merged
merged 3 commits into from Jul 15, 2019

Conversation

@dr3dd589
Copy link
Member

dr3dd589 commented Jul 13, 2019

fix #1338

Note: DefectDojo is now on Python3 and Django 2.2.1 Please submit your pull requests to the 'dev' branch as the 'legacy-python2.7' branch is only for bug fixes. Any new features submitted to the legacy branch will be ignored and closed.

When submitting a pull request, please make sure you have completed the following checklist:

  • Your code is flake8 compliant
  • If this is a new feature and not a bug fix, you've included the proper documentation in the ReadTheDocs documentation folder. https://github.com/DefectDojo/Documentation/tree/master/docs or provide feature documentation in the PR.
  • Model changes must include the necessary migrations in the dojo/dd_migrations folder.
  • Add applicable tests to the unit tests.
@madchap

This comment has been minimized.

Copy link
Contributor

madchap commented Jul 14, 2019

Package mysql-client is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source
E: Package 'mysql-client' has no installation candidate

My PR had the same, guessing something changed there?

@Maffooch

This comment has been minimized.

Copy link
Collaborator

Maffooch commented Jul 15, 2019

The docker breakage from this weekend has been fixed. Please pull the fix and push again for travis to run. I will approve after the test passes. Good work on fixing the issue.

@dr3dd589 dr3dd589 force-pushed the dr3dd589:varacode_fix branch from 42f0784 to 193d777 Jul 15, 2019
@dr3dd589 dr3dd589 changed the title Varacode fix static and dynamic issue Veracode fix static and dynamic issue Jul 15, 2019
@devGregA devGregA merged commit 96269f4 into DefectDojo:dev Jul 15, 2019
4 checks passed
4 checks passed
AccessLint Review complete
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - components/package.json (aaronweaver (GitHub marketplace)) No manifest changes detected
security/snyk - requirements.txt (aaronweaver (GitHub marketplace)) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.