Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tags in reports #1400

Merged
merged 3 commits into from Jul 23, 2019

Conversation

@dr3dd589
Copy link
Member

dr3dd589 commented Jul 22, 2019

fix #1378

Note: DefectDojo is now on Python3 and Django 2.2.1 Please submit your pull requests to the 'dev' branch as the 'legacy-python2.7' branch is only for bug fixes. Any new features submitted to the legacy branch will be ignored and closed.

When submitting a pull request, please make sure you have completed the following checklist:

  • Your code is flake8 compliant
  • If this is a new feature and not a bug fix, you've included the proper documentation in the ReadTheDocs documentation folder. https://github.com/DefectDojo/Documentation/tree/master/docs or provide feature documentation in the PR.
  • Model changes must include the necessary migrations in the dojo/dd_migrations folder.
  • Add applicable tests to the unit tests.
@madchap

This comment has been minimized.

Copy link
Contributor

madchap commented Jul 23, 2019

I haven't really looked in the report code, but I see filenames are all PDFs? (which I have yet to see as a report type? Am I missing something?)

@dr3dd589

This comment has been minimized.

Copy link
Member Author

dr3dd589 commented Jul 23, 2019

No, just generate the report in HTML.

@NRGLine4Sec

This comment has been minimized.

Copy link

NRGLine4Sec commented Jul 23, 2019

@dr3dd589 Do you think it's possible to add the ability to export report as PDF as I suggest in #1299 ?

@Maffooch

This comment has been minimized.

Copy link
Collaborator

Maffooch commented Jul 23, 2019

@dr3dd589 Would you be able to implement these changes across all reporting templates? When I made modifications to reports, I would filter the the directory by file name containing "report" and modify all files where applicable. Thanks in advance.

@dr3dd589

This comment has been minimized.

Copy link
Member Author

dr3dd589 commented Jul 23, 2019

@Maffooch done thanks! @NRGLine4Sec I can try that but as Greg said there were problems when this functionality was implemented that's why it is removed.

@Maffooch

This comment has been minimized.

Copy link
Collaborator

Maffooch commented Jul 23, 2019

@dr3dd I hate to be a stickler, but the following reports need to be updated as well.

  • asciidoc_report
  • custom_asciidoc_report_endpoints
  • custom_asciidoc_report_findings
  • endpoint_pdf_report
  • product_endpoint_pdf_report
  • product_pdf_report
  • product__type_pdf_report
@dr3dd589

This comment has been minimized.

Copy link
Member Author

dr3dd589 commented Jul 23, 2019

thanks again! didn't notice there is too many reports template.

@devGregA devGregA merged commit c0a0721 into DefectDojo:dev Jul 23, 2019
4 checks passed
4 checks passed
AccessLint Review complete
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - components/package.json (aaronweaver (GitHub marketplace)) No manifest changes detected
security/snyk - requirements.txt (aaronweaver (GitHub marketplace)) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.