Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dependency parser #1455

Merged
merged 6 commits into from Aug 8, 2019

Conversation

@dr3dd589
Copy link
Member

dr3dd589 commented Aug 6, 2019

fix #1393
according to @madchap reported issue I see maybe in new exported dependency parser namespace are not available. Although he did not provide any sample for that to reproduce this issue. I added a try and exception to fix this. Maybe this will fix this.

  • Your code is flake8 compliant
  • If this is a new feature and not a bug fix, you've included the proper documentation in the ReadTheDocs documentation folder. https://github.com/DefectDojo/Documentation/tree/master/docs or provide feature documentation in the PR.
  • Model changes must include the necessary migrations in the dojo/dd_migrations folder.
  • Add applicable tests to the unit tests.
@ptrovatelli

This comment has been minimized.

Copy link
Contributor

ptrovatelli commented Aug 6, 2019

Hi @dr3dd589 . I came across this one too. I've just added a sample report here if you want to test your fix:
DefectDojo/sample-scan-files#34
Thanks!

@ptrovatelli

This comment has been minimized.

Copy link
Contributor

ptrovatelli commented Aug 6, 2019

btw this PR is about this issue: #1393

dr3dd589 added 2 commits Aug 6, 2019
@dr3dd589

This comment has been minimized.

Copy link
Member Author

dr3dd589 commented Aug 6, 2019

done! @ptrovatelli thanks. Importer works fine now with your sample too.

@devGregA devGregA merged commit 1dae800 into DefectDojo:dev Aug 8, 2019
4 checks passed
4 checks passed
AccessLint Review complete
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - components/package.json (aaronweaver (GitHub marketplace)) No manifest changes detected
security/snyk - requirements.txt (aaronweaver (GitHub marketplace)) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.