Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return dedupe to a "working" state #1508

Merged
merged 2 commits into from Aug 20, 2019

Conversation

@Maffooch
Copy link
Contributor

commented Aug 19, 2019

Note: DefectDojo is now on Python3 and Django 2.2.1 Please submit your pull requests to the 'dev' branch as the 'legacy-python2.7' branch is only for bug fixes. Any new features submitted to the legacy branch will be ignored and closed.

In response to #1478, deduplication now allows line numbers specified as 'None' to be valid, and therefore a candidate for deduplication. This is NOT a final solution, nor as a distraction or mitigation of the bigger problem. This is purely meant as a temporary method for users that are accustomed to the previous implementation.

  • Your code is flake8 compliant
  • If this is a new feature and not a bug fix, you've included the proper documentation in the ReadTheDocs documentation folder. https://github.com/DefectDojo/Documentation/tree/master/docs or provide feature documentation in the PR.
  • Model changes must include the necessary migrations in the dojo/dd_migrations folder.
  • Add applicable tests to the unit tests.
Maffooch Maffooch
@Maffooch Maffooch requested a review from DefectDojo/defectdojo-moderators Aug 19, 2019
Maffooch Maffooch
@Maffooch

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

The close_old_findings feature has been reintroduced, but does not do anything. I had never used it before axing it, so not exactly sure how it suppose to work. The original code is in the same place as before. Just needs a little makeover.

@madchap

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

Didn't work in my specific case at least.

@Maffooch

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2019

@madchap could you provide a little info as to why it’s not working? What scanner are you using? Are there any values that are not provided?

@devGregA devGregA merged commit 33f60a4 into DefectDojo:dev Aug 20, 2019
4 checks passed
4 checks passed
AccessLint Review complete
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - components/package.json (aaronweaver (GitHub marketplace)) No manifest changes detected
security/snyk - requirements.txt (aaronweaver (GitHub marketplace)) No manifest changes detected
@liketop liketop referenced this pull request Sep 3, 2019
1 of 3 tasks complete
@Maffooch Maffooch deleted the Maffooch:dedupe branch Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.