Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing threading from ptvsd entrypoint #1787

Merged
merged 2 commits into from Jan 22, 2020

Conversation

@madchap
Copy link
Contributor

madchap commented Jan 19, 2020

Running ptvsd with threads and potentially multi-processes will mess with you soon or later.

If you're debugging something anyways, you probably do not need multiple threads, but rather will like to have 100% of your breakpoints work or hot-reload to be super fast.

fyi @ptrovatelli

@madchap madchap changed the title removing threading from ptvsd, as it will mess with you. Removing threading from ptvsd entrypoint Jan 19, 2020
@ptrovatelli

This comment has been minimized.

Copy link
Contributor

ptrovatelli commented Jan 21, 2020

this used to be --enable-threads --lazy-apps --honour-stdin at 9cb619c

i haven't tested without --enable-threads, I guess it's the same

have you tested a bit with this configuration?

@madchap

This comment has been minimized.

Copy link
Contributor Author

madchap commented Jan 22, 2020

Hey @ptrovatelli,

Yes, it works. However, I read some documentation this morning after reading your answer, and it seems to be somehow "required" to have it for python background threads -- as far as uwsgi. In our case, it does work without it, but i guess it is better to go "by the book".

Therefore, I pushed a commit to put it back in there. We know it works too, so no problem there.

Thanks.

@ptrovatelli

This comment has been minimized.

Copy link
Contributor

ptrovatelli commented Jan 22, 2020

thanks :)

@ptrovatelli ptrovatelli merged commit a0a6e04 into DefectDojo:dev Jan 22, 2020
4 checks passed
4 checks passed
AccessLint Review complete
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - components/package.json (aaronweaver (GitHub marketplace)) No manifest changes detected
security/snyk - requirements.txt (aaronweaver (GitHub marketplace)) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.