Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade NodeJS and Fixing issue #1931 #1937

Merged
merged 1 commit into from Feb 28, 2020
Merged

Upgrade NodeJS and Fixing issue #1931 #1937

merged 1 commit into from Feb 28, 2020

Conversation

@arkwrn
Copy link
Contributor

arkwrn commented Feb 28, 2020

  • Upgarde NodeJS version :
    Upgrade from version 11.x to 12.x due to decprecation warning, since nodejs 11.x is no longer actively supported
================================================================================
================================================================================

                              DEPRECATION WARNING                            

  Node.js 11.x is no longer actively supported!

  You will not receive security or critical stability updates for this version.

  You should migrate to a supported version of Node.js as soon as possible.
  Use the installation script that corresponds to the version of Node.js you
  wish to install. e.g.

   * https://deb.nodesource.com/setup_10.x — Node.js 10 LTS "Dubnium" (recommended)
   * https://deb.nodesource.com/setup_12.x — Node.js 12 LTS "Erbium"

  Please see https://github.com/nodejs/Release for details about which
  version may be appropriate for you.

  The NodeSource Node.js distributions repository contains
  information both about supported versions of Node.js and supported Linux
  distributions. To learn more about usage, see the repository:
    https://github.com/nodesource/distributions

================================================================================
================================================================================
  • Fixing issue when building nginx image (#1931)
- Updating nodejs from 11.x to 12.x due to decprecation warning, since nodejs 11.x is no longer actively supported

```
================================================================================
================================================================================

                              DEPRECATION WARNING                            

  Node.js 11.x is no longer actively supported!

  You will not receive security or critical stability updates for this version.

  You should migrate to a supported version of Node.js as soon as possible.
  Use the installation script that corresponds to the version of Node.js you
  wish to install. e.g.

   * https://deb.nodesource.com/setup_10.x — Node.js 10 LTS "Dubnium" (recommended)
   * https://deb.nodesource.com/setup_12.x — Node.js 12 LTS "Erbium"

  Please see https://github.com/nodejs/Release for details about which
  version may be appropriate for you.

  The NodeSource Node.js distributions repository contains
  information both about supported versions of Node.js and supported Linux
  distributions. To learn more about usage, see the repository:
    https://github.com/nodesource/distributions

================================================================================
================================================================================
```

- Fixing issue when building nginx image (#1931)
Copy link
Contributor

ptrovatelli left a comment

thanks that fixes it indeed!

a few thoughts though:

  • yarn: why not stick to stable? wasn't working?
  • i think we should pin the versions: install a specified version of node and yarn instead of the latest one. that will hopefully prevent this kind of erratic behavior in the future. we have a dependency bot that can (hopefully) warn us when a new version is available for us to upgrade while keeping control on it.
@arkwrn

This comment has been minimized.

Copy link
Contributor Author

arkwrn commented Feb 28, 2020

thanks that fixes it indeed!

a few thoughts though:

  • yarn: why not stick to stable? wasn't working?
  • i think we should pin the versions: install a specified version of node and yarn instead of the latest one. that will hopefully prevent this kind of erratic behavior in the future. we have a dependency bot that can (hopefully) warn us when a new version is available for us to upgrade while keeping control on it.

I need a quick fix that's why I try to do a tracing problem and find the fastest way to do that is to use the nightly version, I totally agree with you to freeze the version, but I'm sorry at this time I still don't have much time to test the version which yarn is good to use, hopefully the others can help to do the trial 😄

@madchap

This comment has been minimized.

Copy link
Contributor

madchap commented Feb 28, 2020

We'll have to revisit this when yarn 1.23 makes it into stable.
But for now, it is needed to build the nginx so.. merging.

@madchap madchap merged commit a41ab5a into DefectDojo:dev Feb 28, 2020
3 checks passed
3 checks passed
AccessLint Review complete
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk (aaronweaver (GitHub marketplace)) No manifest changes detected
Details
@arkwrn arkwrn deleted the arkwrn:patch-1 branch Feb 28, 2020
@arkwrn arkwrn restored the arkwrn:patch-1 branch Mar 2, 2020
@arkwrn

This comment has been minimized.

Copy link
Contributor Author

arkwrn commented Mar 2, 2020

Hi @madchap , @ptrovatelli I have tested for a yarn package manager stable version that can be used and I think it is enough to use, the version that I confirmed is the stable version 1.21.0 (#1956)

@valentijnscholten valentijnscholten mentioned this pull request Mar 3, 2020
3 of 5 tasks complete
madchap added a commit to madchap/django-DefectDojo that referenced this pull request Mar 5, 2020
madchap added a commit that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.