Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvements #5090

Merged
merged 4 commits into from Sep 14, 2021
Merged

UI improvements #5090

merged 4 commits into from Sep 14, 2021

Conversation

StefanFl
Copy link
Member

@StefanFl StefanFl commented Sep 13, 2021

Inspired by #5074 I implemented some more UI improvements. The examples here show how it looks with this PR:

  • Gaps were missing between some icons:
    2021-09-13 17_41_11-Findings _ DefectDojo
    2021-09-13 17_50_24-View Finding _ DefectDojo

  • Put Page Size and icon in one button, looks cleaner and Page Size was a button without functionality:
    2021-09-13 17_41_35-Findings _ DefectDojo

  • Apply Filters button wasn't visible anymore because it was white:
    2021-09-13 17_41_57-Findings _ DefectDojo

  • Moved the questions marks further left behind the titles of the heading and made them white:
    2021-09-13 17_44_00-View Product Type _ DefectDojo

  • The Notes header in findings and tests is now blue as all the other headings:
    2021-09-13 19_15_18-View Finding _ DefectDojo

Copy link
Contributor

@Maffooch Maffooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOVE these improvements! Does #5074 need to be merged before this?

@StefanFl
Copy link
Member Author

It is already merged 😃

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving the polish!

Approved

@mtesauro mtesauro merged commit d990e90 into DefectDojo:dev Sep 14, 2021
@StefanFl StefanFl deleted the ui-improvements branch September 17, 2021 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants