New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `@types/google-apps-script` Advanced Service #29349

Open
grant opened this Issue Oct 2, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@grant
Contributor

grant commented Oct 2, 2018

Add Advanced Service types to @types/google-apps-script.

A list of Advanced Services can be found here:
https://developers.google.com/apps-script/advanced/adsense

@j-frost

This comment has been minimized.

j-frost commented Oct 18, 2018

I've got a contribution for google-apps-script-tests.ts:

function getTotalUsers(): number {
    let pageToken;
    let totalUsers = 0;
    do {
        let result = AdminReseller.Subscriptions.list({pageToken: pageToken});
        const subscriptions = result.subscriptions.filter(function (subscription) {
            return subscription.skuName.indexOf('G Suite') >= 0
        });
        for (let subscription of subscriptions) {
            const planName: string = subscription.plan.planName;
            if (planName.indexOf('ANNUAL') >= 0) {
                totalUsers += subscription.seats.numberOfSeats;
            }
            else if (planName == 'FLEXIBLE' || planName == 'TRIAL') {
                totalUsers += subscription.seats.licensedNumberOfSeats;
            }
        }
        pageToken = result.nextPageToken;
    } while (pageToken);
    log(`Reporting ${totalUsers} total users`);
    return totalUsers;
}

For now, this is the only service that really hurts in its absence, but we've got a few projects in the pipeline where I might come back and expand the list.

I will definitely write a blog post and reference it here, because I really think both the typings and claps itself are super valuable in making development of GAS much less painful.

I've heard it's difficult for you guys to add typings for AppMaker in a similar fashion because AppMaker uses proprietary tools/code. While I understand that this is the case, we've been asked multiple times now by clients and colleagues alike whether similar support will ever come. Developers really like their IDEs, as it were.

@j-frost

This comment has been minimized.

j-frost commented Oct 30, 2018

Alright @grant , we have the blog post online (en_US, de_DE).

I have added some superficial descriptions of the new DataStudioApp in the posts, and I'd also like to request it here. Really helpful, those builders! :)

@alexgoldsilver

This comment has been minimized.

alexgoldsilver commented Nov 8, 2018

Ditto on the request for DataStudioApp in here, as it's some of the most complex development best done locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment