add walk and walkSync to fs-extra #13103

Merged
merged 4 commits into from Jan 9, 2017

Projects

None yet

4 participants

@shiftkey
Contributor
shiftkey commented Dec 5, 2016

Please fill in this template.

  • Prefer to make your PR against the types-2.0 branch.
  • Test the change in your own code.
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • [ ] Run npm run lint -- package-name if a tslint.json is present.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes:
  • [ ] Increase the version number in the header if appropriate.
@dt-bot
Member
dt-bot commented Dec 5, 2016 edited

fs-extra/index.d.ts

to author (@midknight41). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?
@shiftkey
Contributor
shiftkey commented Dec 5, 2016

Although the walk and walkSync methods here are based on Readable I haven't gone and fleshed out these completely - I mostly focused on the example code and the APIs I'm currently using...

@shiftkey shiftkey changed the title from [WIP] add walk and walkSync to fs-extra to add walk and walkSync to fs-extra Dec 8, 2016
@vvakame vvakame changed the base branch to DefinitelyTyped:master from DefinitelyTyped:types-2.0 Dec 24, 2016
@vvakame
Member
vvakame commented Dec 24, 2016

sorry for late..
Could you rebase to master/HEAD?
If we can't get response from author still, I'll merge this PR.

fs-extra/index.d.ts
}
+
+export interface Stats {
@andy-ms
andy-ms Dec 27, 2016 Contributor

Could you just use import { Stats } from "fs";?

@shiftkey
shiftkey Jan 8, 2017 Contributor

Yeah, this was added on a subsequent PR. No longer needed here.

fs-extra/fs-extra-tests.ts
+ return basename === '.' || basename[0] !== '.'
+}
+
+const sortPaths = (left: string, right: string): number => {
@andy-ms
andy-ms Dec 27, 2016 Contributor

Tests don't actually run, so only the types matter. So this could just be (left: string, right: string) => left.localeCompare(right)`.

@shiftkey
Contributor
shiftkey commented Jan 9, 2017

I've rebased this on top of types/2.0 and worked around the subsequent changes which added walk 🤘

@andy-ms andy-ms merged commit d33f090 into DefinitelyTyped:master Jan 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment