Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types for expect v1.20.2 #13779

Merged
1 commit merged into from Jan 6, 2017
Merged

Conversation

merrywhether
Copy link
Contributor

@merrywhether merrywhether commented Jan 5, 2017

Please fill in this template.

  • Make your PR against the master branch.
  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run tsc without errors.
  • Run npm run lint package-name if a tslint.json is present.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <https://github.com/mjackson/expect/blob/master/CHANGES.md>
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "../tslint.json" }.

@dt-bot
Copy link
Member

dt-bot commented Jan 5, 2017

expect/index.d.ts

to author (@jmreidy). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

// Project: https://github.com/mjackson/expect
// Definitions by: Justin Reidy <https://github.com/jmreidy/>
// Definitions by: Risto Keravuori <https://github.com/merrywhether/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write your name on the same line. // Definitions by: Justin Reidy <https://github.com/jmreidy/>, Risto Keravuori <https://github.com/merrywhether/>

@ghost
Copy link

ghost commented Jan 6, 2017

These look good. Longer-term, maybe this could use class Expectation<T> and declare function expect<T>(actual: T): expect.Expectation<T>; to help refine some of the methods there?

@merrywhether
Copy link
Contributor Author

Thanks for the tip! Tried adding as much generics as made sense. Learning so much about TS doing this.

@ghost ghost merged commit 6db421e into DefinitelyTyped:master Jan 6, 2017
@merrywhether merrywhether deleted the expect branch January 6, 2017 04:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants