Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accepts definition, update raw-body #14417

Merged
merged 1 commit into from Feb 5, 2017
Merged

Improve accepts definition, update raw-body #14417

merged 1 commit into from Feb 5, 2017

Conversation

blakeembrey
Copy link
Member

Please fill in this template.

  • Make your PR against the master branch.
  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run tsc without errors.
  • Run npm run lint package-name if a tslint.json is present.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/jshttp/accepts
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "../tslint.json" }.

@dt-bot
Copy link
Member

dt-bot commented Feb 3, 2017

accepts/index.d.ts

to author (@Bomret). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

raw-body/index.d.ts

to author (@Bomret). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

Copy link
Contributor

@Bomret Bomret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks 👍

@blakeembrey blakeembrey merged commit f4f0bef into DefinitelyTyped:master Feb 5, 2017
@blakeembrey blakeembrey deleted the improve-accepts branch February 5, 2017 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants