Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suppressContentEditableWarning to react #14955

Merged
merged 1 commit into from Mar 9, 2017
Merged

Add suppressContentEditableWarning to react #14955

merged 1 commit into from Mar 9, 2017

Conversation

gaspard
Copy link
Contributor

@gaspard gaspard commented Mar 2, 2017

Please fill in this template.

  • Make your PR against the master branch.
  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run tsc without errors.
  • Run npm run lint package-name if a tslint.json is present.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: Add suppressContentEditableWarning facebook/react#6112
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "../tslint.json" }.

* react: add support for the new suppressContentEditableWarning flag
facebook/react#6112
@dt-bot
Copy link
Member

dt-bot commented Mar 2, 2017

react/index.d.ts

to authors (@pspeter3 @vsiao @johnnyreilly @bbenezech @pzavolinsky @digiguru AssureSign (account can't be detected) Microsoft (account can't be detected)). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

@vsiao
Copy link
Contributor

vsiao commented Mar 3, 2017

Has this been released yet?

@gaspard
Copy link
Contributor Author

gaspard commented Mar 4, 2017

I don't think so...

It's a tiny commit. Hope it gets merged in as soon as possible...

@minestarks minestarks merged commit 021efcf into DefinitelyTyped:master Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants