Skip to content

Create definitions for jquery.growl#16055

Merged
mhegazy merged 2 commits into
DefinitelyTyped:masterfrom
yeganemehr:master
May 1, 2017
Merged

Create definitions for jquery.growl#16055
mhegazy merged 2 commits into
DefinitelyTyped:masterfrom
yeganemehr:master

Conversation

@yeganemehr

Copy link
Copy Markdown
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not provide its own types, and you can not add them.
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, and strictNullChecks set to true.

This adds types for jquery-growl.

@dt-bot

dt-bot commented Apr 21, 2017

Copy link
Copy Markdown
Member

types/jquery.growl/index.d.ts

Checklist

@ghost

ghost commented Apr 21, 2017

Copy link
Copy Markdown

Please look at the test failures.

@yeganemehr

Copy link
Copy Markdown
Contributor Author

Hi @Andy-MS
I Fixed Travis CI checks and It should good to go!

@ghost

ghost commented Apr 23, 2017

Copy link
Copy Markdown

This could still use a test. You could just use this from its homepage:

$.growl({ title: "Growl", message: "The kitten is awake!" });
$.growl.error({ message: "The kitten is attacking!" });
$.growl.notice({ message: "The kitten is cute!" });
$.growl.warning({ message: "The kitten is ugly!" });

@mhegazy
mhegazy merged commit 876b72a into DefinitelyTyped:master May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants