Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@types/uikit added missing types for importing uikit #16104

Closed
wants to merge 2 commits into from

Conversation

@Talalaev
Copy link

Talalaev commented Apr 24, 2017

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not provide its own types, and you can not add them.
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, and strictNullChecks set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dslint/dt.json" }.

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.
@dt-bot

This comment has been minimized.

Copy link
Member

dt-bot commented Apr 24, 2017

types/uikit/index.d.ts

to authors (@giovannicandido @s0x). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?
@sheetalkamat

This comment has been minimized.

Copy link
Contributor

sheetalkamat commented Apr 25, 2017

Needs a tslint.json containing { "extends": "dtslint/dt.json" }
Also update/add test

@mhegazy

This comment has been minimized.

Copy link
Contributor

mhegazy commented May 5, 2017

@Talalaev since this is a major version, please create a new v2 folder, copy the old files, before your change. please see https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#i-want-to-update-a-package-to-a-new-major-version for more info.

@aozgaa

This comment has been minimized.

Copy link
Contributor

aozgaa commented May 17, 2017

@Talalaev this looks like a nice contribution, but we can't take the change in its current state. Please follow the advice above and additionally fill out the template.

If there is no activity here within a week or two, we will be forced to close the PR.

@andy-ms andy-ms mentioned this pull request Jun 1, 2017
3 of 15 tasks complete
@mhegazy

This comment has been minimized.

Copy link
Contributor

mhegazy commented Jun 5, 2017

Thanks for your contribution. This PR can not be merged in at the time being. For housekeeping purposes we are closing stale PRs. If you'd still like to merge this code in, please open a new PR that has been merged and rebased with the master branch.

@mhegazy mhegazy closed this Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.