fix(cordova-plugin-inappbrowser): add missing entry of InAppBrowser to Cordova interface #17192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does anyone know what's wrong with @dt-bot? |
minestarks
suggested changes
Jun 16, 2017
| * name/value pairs must be separated by a comma. Feature names are case insensitive. | ||
| */ | ||
| open(url: string, target?: string, options?: string, replace?: boolean): InAppBrowser; | ||
| open(url: string, target?: target | string, options?: string, replace?: boolean): InAppBrowser; |
There was a problem hiding this comment.
target | string is the same type as string . If you don't care for the overloads I suggest removing target altogether.
timbru31
force-pushed
the
fix-cordova-inappbrowser
branch
from
c7a0748
to
7b1d4d2
Compare
2 tasks
2 tasks
janpio
pushed a commit
to apache/cordova-plugin-inappbrowser
that referenced
this pull request
Oct 2, 2018
### Platforms affected n/a - development with TypeScript ### What does this PR do? Updates the typings to match the latest published version on DefinitelyTyped. See DefinitelyTyped/DefinitelyTyped#17192 and https://stackoverflow.com/q/42095516/1902598 ### What testing has been done on this change? Project compiles again ;) ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. - n/a: Added automated test coverage as appropriate for this change. fixes #300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing interface entry of
InAppBrowsertoCordovain order to fixProperty 'InAppBrowser' does not exist on type 'Cordova'.Besides that it enables linting of the types and fixes the reported errors.
npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.