Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type definitions for Yup #21857

Merged
merged 10 commits into from Dec 11, 2017

Conversation

@vtserman
Copy link
Contributor

commented Nov 30, 2017

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).
  • The package does not provide its own types, and you can not add them.
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.
@dt-bot

This comment has been minimized.

Copy link
Member

commented Nov 30, 2017

types/yup/index.d.ts

Checklist

@vtserman vtserman changed the title [Request] Type definitions for Yup Type definitions for Yup Nov 30, 2017

@vtserman vtserman referenced this pull request Nov 30, 2017

@typescript-bot typescript-bot added this to New Definitions in Pull Request Triage Backlog Nov 30, 2017

@@ -0,0 +1,7 @@
{
"extends": "dtslint/dt.json",
"rules": {

This comment has been minimized.

Copy link
@plantain-00

plantain-00 Dec 1, 2017

Contributor

For new packages, it should only "extends": "dtslint/dt.json"

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Dec 1, 2017

@plantain-00 - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate?

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Dec 4, 2017

Approved by third party. PR appears ready to merge pending review by a maintainer.

@typescript-bot typescript-bot moved this from New Definitions to Merge: LGTM in Pull Request Triage Backlog Dec 4, 2017

@typescript-bot typescript-bot moved this from Merge: LGTM to New Definitions in Pull Request Triage Backlog Dec 7, 2017

@typescript-bot typescript-bot moved this from New Definitions to Merge: LGTM in Pull Request Triage Backlog Dec 10, 2017

@minestarks minestarks merged commit 9f8f171 into DefinitelyTyped:master Dec 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@typescript-bot typescript-bot removed this from Merge: LGTM in Pull Request Triage Backlog Dec 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.