Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types for styled-jsx #22181

Merged
merged 5 commits into from Dec 23, 2017

Conversation

Projects
None yet
5 participants
@lesnitsky
Copy link
Contributor

commented Dec 14, 2017

No description provided.

Andrei Volchenko
@dt-bot

This comment has been minimized.

Copy link
Member

commented Dec 14, 2017

types/styled-jsx/index.d.ts

Checklist

@lesnitsky lesnitsky referenced this pull request Dec 14, 2017

Closed

Typescript typings #90

Andrei Volchenko added some commits Dec 14, 2017

Andrei Volchenko
Andrei Volchenko
Andrei Volchenko
{
"extends": "dtslint/dt.json",
"rules": {
"dt-header": false,

This comment has been minimized.

Copy link
@plantain-00

plantain-00 Dec 15, 2017

Contributor

For new packages, this file should only "extends": "dtslint/dt.json"

This comment has been minimized.

Copy link
@lesnitsky

lesnitsky Dec 15, 2017

Author Contributor

@plantain-00 fixed

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Dec 15, 2017

@R1ZZU Please address comments from the code reviewers.

Andrei Volchenko
@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Dec 18, 2017

We've gotten sign-off from a reviewer 👏. A maintainer will soon review this PR and merge it if there are no issues. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for contributing to DefinitelyTyped!

@typescript-bot typescript-bot moved this from New Definitions to Merge: LGTM in Pull Request Triage Backlog Dec 18, 2017

@aozgaa aozgaa merged commit 243da4a into DefinitelyTyped:master Dec 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@typescript-bot typescript-bot removed this from Merge: LGTM in Pull Request Triage Backlog Dec 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.