Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fuzzyset] - Make sure optional params remain optional #23502

Merged

Conversation

@narainsagar
Copy link
Contributor

@narainsagar narainsagar commented Feb 8, 2018

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified (@types/fuzzyset + @types/fuzzyset.js)
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@narainsagar
Copy link
Contributor Author

@narainsagar narainsagar commented Feb 8, 2018

Hi @lgrignon Can you please review this change? Thanks!

@lgrignon
Copy link
Contributor

@lgrignon lgrignon commented Feb 8, 2018

+1

@typescript-bot
Copy link
Contributor

@typescript-bot typescript-bot commented Feb 8, 2018

@narainsagar Thank you for submitting this PR!

🔔 @lgrignon - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

@typescript-bot typescript-bot commented Feb 8, 2018

A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@DanielRosenwasser DanielRosenwasser merged commit 04ffde8 into DefinitelyTyped:master Feb 11, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@typescript-bot typescript-bot removed this from Merge: Express in Pull Request Triage Backlog Feb 11, 2018
@narainsagar narainsagar deleted the narainsagar:fix-fuzzyset-types branch Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.