Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fuzzyset] - Make sure optional params remain optional #23502



Copy link

@narainsagar narainsagar commented Feb 8, 2018

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified (@types/fuzzyset + @types/fuzzyset.js)
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

Copy link
Contributor Author

Hi @lgrignon Can you please review this change? Thanks!

Copy link

lgrignon commented Feb 8, 2018


Copy link

typescript-bot commented Feb 8, 2018

@narainsagar Thank you for submitting this PR!

🔔 @lgrignon - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

Copy link

A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@DanielRosenwasser DanielRosenwasser merged commit 04ffde8 into DefinitelyTyped:master Feb 11, 2018
@typescript-bot typescript-bot removed this from Merge: Express in Pull Request Triage Backlog Feb 11, 2018
@narainsagar narainsagar deleted the fix-fuzzyset-types branch February 12, 2018 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants