Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expo - Included result.type, base64, exif in ImageLibrary API as per docs #24306

Merged
merged 1 commit into from Mar 15, 2018

Conversation

@jhalborg
Copy link
Contributor

commented Mar 15, 2018

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2018

@jhalborg Thank you for submitting this PR!

🔔 @KonstantinKai @martynaskadisa @janaagaard75 @ssanchezmarc @fhelwanger - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@KonstantinKai
Copy link
Contributor

left a comment

@jhalborg thanks for your contribution 👍

@janaagaard75

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2018

Looks good.

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2018

A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@fhelwanger
Copy link
Contributor

left a comment

Looks good, thanks!

@aozgaa aozgaa merged commit 4fb017a into DefinitelyTyped:master Mar 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@typescript-bot typescript-bot removed this from Merge: Express in Pull Request Triage Backlog Mar 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.