New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[three] BufferGeometry.setFromPoints accepts Vector2s as well #25897

Merged
merged 1 commit into from May 23, 2018

Conversation

Projects
None yet
4 participants
@fordhurley
Copy link
Contributor

fordhurley commented May 20, 2018

The documentation shows examples of this, e.g.:

https://threejs.org/docs/#api/extras/curves/EllipseCurve

The source code shows how it handles an array of either type:

https://github.com/mrdoob/three.js/blob/2f2e5f731/src/core/BufferGeometry.js#L352

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

@typescript-bot

This comment has been minimized.

Copy link

typescript-bot commented May 20, 2018

@fordhurley Thank you for submitting this PR!

🔔 @gyohk @florentpoujol @SereznoKot @omni360 @ivoisbelongtous @piranha771 @qszhusightp @nakakura @s093294 @Pro @efokschaner @PsychoSTS @dhritzkiv @apurvaojas - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@efokschaner
Copy link
Contributor

efokschaner left a comment

Thanks for the improvement.
I approve of the change as is.

Potentially an array of anything with x and y and z? members would suffice, but I always wonder whether three expects these to be vector classed objects even if it doesn't depend on that right now...

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Check and Merge in Pull Request Status Board May 20, 2018

@typescript-bot

This comment has been minimized.

Copy link

typescript-bot commented May 20, 2018

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@DanielRosenwasser DanielRosenwasser merged commit b062863 into DefinitelyTyped:master May 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@DanielRosenwasser

This comment has been minimized.

Copy link
Collaborator

DanielRosenwasser commented May 23, 2018

Thanks all!

@typescript-bot typescript-bot removed this from Check and Merge in Pull Request Status Board May 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment