Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d3-color : added piecewise method #25920

Merged
merged 6 commits into from Jun 1, 2018

Conversation

Ledragon
Copy link
Contributor

#25582

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: 1.2.0
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

@typescript-bot
Copy link
Contributor

typescript-bot commented May 21, 2018

@Ledragon Thank you for submitting this PR!

🔔 @tomwanzek @gustavderdrache @borisyankov - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

@Ledragon The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot typescript-bot moved this from Needs Author Attention to Waiting for Reviewers in Pull Request Status Board May 21, 2018
@typescript-bot typescript-bot moved this from Waiting for Reviewers to Review in Pull Request Status Board May 26, 2018
@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label May 26, 2018
@typescript-bot
Copy link
Contributor

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@uniqueiniquity uniqueiniquity merged commit 96f79c2 into DefinitelyTyped:master Jun 1, 2018
@Ledragon Ledragon deleted the d3-interpolate-120 branch June 2, 2018 10:03
@Ledragon
Copy link
Contributor Author

Ledragon commented Jun 2, 2018

@tomwanzek @denisname With this closed I think the global bundle can be bumped to 5.2.0. Shall I go fot this? Is there a way to bind the bundle to specific modules version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Unmerged The author did not merge the PR when it was ready.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants