Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional builtAt key to webpack.Configuration.stats #26589

Merged

Conversation

Projects
None yet
4 participants
@g-harel
Copy link
Contributor

commented Jun 15, 2018

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

@g-harel g-harel changed the title Add optional builtAt key to @types/webpack.Configuration.stats Add optional builtAt key to webpack.Configuration.stats Jun 15, 2018

@typescript-bot typescript-bot added this to Waiting for Reviewers in Pull Request Status Board Jun 15, 2018

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Jun 15, 2018

@g-harel Thank you for submitting this PR!

🔔 @tkqubo @bumbleblym @bcherny @tommytroylin @mohsen1 @jcreamer898 @ahmed-taj @alan-agius4 @elliottsj @jason0x43 @dennispg @christophehurpeau - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Jun 20, 2018

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@alan-agius4
Copy link
Contributor

left a comment

Thanks, LGTM. and apologies for not reviewing this earlier

@typescript-bot typescript-bot moved this from Review to Check and Merge in Pull Request Status Board Jun 20, 2018

@sandersn sandersn merged commit 594baf3 into DefinitelyTyped:master Jun 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@typescript-bot typescript-bot removed this from Check and Merge in Pull Request Status Board Jun 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.