Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Bull: Add types to some private functions #27816
Me and my team are using these functions to implement a multiple-repo job processor service (despite being told by the author that this pattern for Bull isn't supported or planned). We are manually moving jobs from state to state as the
Please fill in this template.
Select one of these and delete the others:
If changing an existing definition:
@aleccool213 Thank you for submitting this PR!
If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.
moved this from Waiting for Reviewers
in Pull Request Status Board
Aug 7, 2018
I would be wary about making "private" APIs public in a package, especially when the package author has expressly indicated that these APIs are private and may change. Are you able to use a module augmentation in your own project to add these APIs for your own internal use, as opposed to making this change for all users? Alternatively, are you able to work with the package author to find ways of making these APIs public first? Unless there is a very compelling case for adding these types for the entire development community, I would caution against adding them here.
@aleccool213: I would like to postpone merging until that PR has been merged, in the event the package author requires any other API changes, per this comment:
Once that PR has merged and this PR is up to date with any changes, post a comment to this thread and a reviewer will take another look.