Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type of unselectable #28763

Merged
merged 1 commit into from Sep 10, 2018

Conversation

Ailrun
Copy link
Contributor

@Ailrun Ailrun commented Sep 10, 2018

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://technet.microsoft.com/en-us/windows/hh801966(v=vs.60)
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

@johnnyreilly johnnyreilly merged commit 0125d65 into DefinitelyTyped:master Sep 10, 2018
@johnnyreilly
Copy link
Member

Thanks!

@Ailrun
Copy link
Contributor Author

Ailrun commented Sep 10, 2018

Oh, it's super fast. Thanks!

@jspurlin
Copy link

@Ailrun and @johnnyreilly fyi, this is a breaking change

@rhyek
Copy link

rhyek commented Nov 7, 2018

I'm getting the following error when updating react, react-dom and their respective `@types packages:

...
    Types of property 'unselectable' are incompatible.
      Type '"off" | "on" | undefined' is not assignable to type 'boolean | undefined'.
        Type '"off"' is not assignable to type 'boolean | undefined'.

How can I fix this?

@Ailrun
Copy link
Contributor Author

Ailrun commented Nov 7, 2018

@rhyek some of your package depends on old react typing. You should check where such different typing comes.

@Ailrun Ailrun deleted the react/fix-unselectable branch April 15, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants