New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types for "factory-girl" #30135

Merged
merged 1 commit into from Oct 30, 2018

Conversation

Projects
None yet
4 participants
@elcuy

elcuy commented Oct 30, 2018

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

@elcuy elcuy force-pushed the stackbuilders:factory_girl branch from 92717bf to abde8b9 Oct 30, 2018

@typescript-bot

This comment has been minimized.

typescript-bot commented Oct 30, 2018

@elcuy Thank you for submitting this PR!

Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

@DanielRosenwasser DanielRosenwasser merged commit 9a9656b into DefinitelyTyped:master Oct 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@DanielRosenwasser

This comment has been minimized.

Collaborator

DanielRosenwasser commented Oct 30, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment