Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[linkifyjs] Add React plugin declaration #31767
If adding a new definition:
thanks for this PR!
I added some comments that make the style of your code in line with that of my submission -- my goal is simply to make sure that the end result is a
I'm fairly new here too, and if any of these suggestions feel weird, just let me know!
(also there are any of the suggestions that you are open to taking but you don't have time, just let me know and I can give you a diff that you can apply.)
moved this from Waiting for Reviewers
to Needs Author Attention
in Pull Request Status Board
Dec 30, 2018
@szhu I just thought of something -- my latest change effectively means the entire declaration now depends on React, even though technically that's just a plugin of linkifyjs. I'm not sure of the ramifications of that, does it mean that the new version of
this looks great! Sorry I have one more suggestion about how the comments are done. Can you make these changes?
It doesn't have to be exactly like this, I'm basically trying to make the header hierarchy more clear.
Thanks! other than that it looks great!