New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sqlstring.raw to sqlstring #31867

Merged
merged 2 commits into from Jan 3, 2019

Conversation

Projects
None yet
4 participants
@davidgomes
Copy link
Contributor

davidgomes commented Jan 3, 2019

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

@typescript-bot

This comment has been minimized.

Copy link

typescript-bot commented Jan 3, 2019

@davidgomes Thank you for submitting this PR!

🔔 @marvinhagemeister - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@marvinhagemeister
Copy link
Contributor

marvinhagemeister left a comment

LGTM, thanks for your contribution 👍 I'm kinda surprised that sqlstring really just used a noop function for raw() but if that's the way they made the package it's good to have the typings reflect it like you did in the PR 👍

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Check and Merge in Pull Request Status Board Jan 3, 2019

@typescript-bot

This comment has been minimized.

Copy link

typescript-bot commented Jan 3, 2019

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@sheetalkamat sheetalkamat merged commit 0c9d6dd into DefinitelyTyped:master Jan 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@typescript-bot typescript-bot removed this from Check and Merge in Pull Request Status Board Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment