Skip to content

[Jest] add test.todo#32569

Merged
armanio123 merged 4 commits into
DefinitelyTyped:masterfrom
DrSensor:master
Feb 5, 2019
Merged

[Jest] add test.todo#32569
armanio123 merged 4 commits into
DefinitelyTyped:masterfrom
DrSensor:master

Conversation

@DrSensor

@DrSensor DrSensor commented Jan 28, 2019

Copy link
Copy Markdown
Contributor

They added test.todo on Jest 24
https://jestjs.io/blog/2019/01/25/jest-24-refreshing-polished-typescript-friendly#testtodo

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. Popular package This PR affects a popular package (as counted by NPM download counts). labels Jan 28, 2019
@typescript-bot

typescript-bot commented Jan 28, 2019

Copy link
Copy Markdown
Contributor

@DrSensor Thank you for submitting this PR!

🔔 @NoHomey @jwbay @asvetliakov @alexjoverm @epicallan @ikatyang @wsmd @JamieMason @douglasduteil @ahnpnl @JoshuaKGoldberg @UselessPickles @r3nya @Hotell @sebald @andys8 - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot

typescript-bot commented Jan 28, 2019

Copy link
Copy Markdown
Contributor

@DrSensor The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Jan 28, 2019
@wsmd wsmd mentioned this pull request Feb 1, 2019
4 tasks
@ilyaulyanov

Copy link
Copy Markdown

Is there an error when any arguments other than name: string are passed into todo?

@typescript-bot

Copy link
Copy Markdown
Contributor

@DrSensor I haven't seen anything from you in a while and this PR currently has problems that prevent it from being merged. The PR will be closed tomorrow if there aren't new commits to fix the issues.

Hope this fix the CI
@typescript-bot

Copy link
Copy Markdown
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@DrSensor

DrSensor commented Feb 4, 2019

Copy link
Copy Markdown
Contributor Author

@ilyaulyanov yes, todo only accept 1 string argument

@armanio123 armanio123 merged commit 6d5170a into DefinitelyTyped:master Feb 5, 2019
@typescript-bot

Copy link
Copy Markdown
Contributor

I just published @types/jest@23.3 to npm.

@typescript-bot

Copy link
Copy Markdown
Contributor

I just published @types/jest@24.0 to npm.

DrSensor added a commit to DrSensor/bot-byte that referenced this pull request Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Other Approved This PR was reviewed and signed-off by a community member. Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants