New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(url-parse): Add optional stringify fn to `toString` #32801

Merged
merged 2 commits into from Feb 6, 2019

Conversation

Projects
None yet
4 participants
@offirgolan
Copy link
Contributor

offirgolan commented Feb 5, 2019

If changing an existing definition:

offirgolan added some commits Feb 5, 2019

@typescript-bot

This comment has been minimized.

Copy link

typescript-bot commented Feb 5, 2019

@offirgolan Thank you for submitting this PR!

🔔 @ChernenkoPaul @harisiva @DimitryDushkin @davidgoli - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@DimitryDushkin

This comment has been minimized.

Copy link
Contributor

DimitryDushkin commented Feb 6, 2019

but test for it will be nice

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Check and Merge in Pull Request Status Board Feb 6, 2019

@typescript-bot

This comment has been minimized.

Copy link

typescript-bot commented Feb 6, 2019

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@armanio123 armanio123 merged commit cff1b62 into DefinitelyTyped:master Feb 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@typescript-bot

This comment has been minimized.

Copy link

typescript-bot commented Feb 6, 2019

I just published @types/url-parse@1.4.3 to npm.

@typescript-bot typescript-bot removed this from Check and Merge in Pull Request Status Board Feb 6, 2019

@offirgolan offirgolan deleted the offirgolan:patch-1 branch Feb 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment