New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add type for "rollup-plugin-buble" #32804

Merged
merged 1 commit into from Feb 5, 2019

Conversation

Projects
None yet
3 participants
@Kocal
Copy link
Contributor

Kocal commented Feb 5, 2019

This PR add typings for rollup-plugin-buble.


Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.
@typescript-bot

This comment has been minimized.

Copy link

typescript-bot commented Feb 5, 2019

@Kocal Thank you for submitting this PR!

Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

@Kocal Kocal force-pushed the Kocal:feat/rollup-plugin-buble branch from 8b65c54 to 86ca25c Feb 5, 2019

@Kocal Kocal changed the title WIP: feat: add type for "rollup-plugin-buble" feat: add type for "rollup-plugin-buble" Feb 5, 2019

@armanio123 armanio123 merged commit 1095664 into DefinitelyTyped:master Feb 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@typescript-bot

This comment has been minimized.

Copy link

typescript-bot commented Feb 5, 2019

@Kocal Kocal deleted the Kocal:feat/rollup-plugin-buble branch Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment