Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upfeat: add type for "rollup-plugin-buble" #32804
Conversation
typescript-bot
added this to Review
in Pull Request Status Board
Feb 5, 2019
This comment has been minimized.
This comment has been minimized.
typescript-bot
commented
Feb 5, 2019
•
@Kocal Thank you for submitting this PR! Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes. In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day! |
Kocal
force-pushed the
Kocal:feat/rollup-plugin-buble
branch
from
8b65c54
to
86ca25c
Feb 5, 2019
Kocal
changed the title
WIP: feat: add type for "rollup-plugin-buble"
feat: add type for "rollup-plugin-buble"
Feb 5, 2019
armanio123
merged commit 1095664
into
DefinitelyTyped:master
Feb 5, 2019
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
typescript-bot
commented
Feb 5, 2019
I just published |
typescript-bot
removed this from Review
in Pull Request Status Board
Feb 5, 2019
Kocal
deleted the
Kocal:feat/rollup-plugin-buble
branch
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Kocal commentedFeb 5, 2019
•
edited
This PR add typings for rollup-plugin-buble.
Please fill in this template.
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).Select one of these and delete the others:
If adding a new definition:
.d.ts
files generated via--declaration
dts-gen --dt
, not by basing it on an existing project.tslint.json
should be present, andtsconfig.json
should havenoImplicitAny
,noImplicitThis
,strictNullChecks
, andstrictFunctionTypes
set totrue
.