Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event specific arg types #34535

Merged
merged 7 commits into from Apr 10, 2019

Conversation

Projects
None yet
4 participants
@joeflateau
Copy link
Contributor

commented Apr 7, 2019

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.
@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Apr 7, 2019

@joeflateau Thank you for submitting this PR!

🔔 @johngeorgewright @steven-joyce - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Needs Author Attention in Pull Request Status Board Apr 8, 2019

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

@joeflateau One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. Thank you!

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

🔔 @johngeorgewright - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate?

@typescript-bot typescript-bot moved this from Needs Author Attention to Check and Merge in Pull Request Status Board Apr 10, 2019

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@uniqueiniquity uniqueiniquity merged commit 322b225 into DefinitelyTyped:master Apr 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Pull Request Status Board automation moved this from Check and Merge to Done Apr 10, 2019

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.