Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rollup-plugin-node-resolve): remove types since package now includes them #34598

Conversation

Projects
None yet
3 participants
@Kocal
Copy link
Contributor

Kocal commented Apr 9, 2019

Since the PR rollup/rollup-plugin-node-resolve#189 has been merged and released in v4.1.0, the package rollup-plugin-node-resolve now includes its own definition types.
So we don't need them anymore here :)

Also note that since rollup/rollup-plugin-node-resolve#206, their options interface has been renamed and exported like we did here, so people won't have to change their code.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.
@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Apr 9, 2019

@Kocal Thank you for submitting this PR!

🔔 @eoin-obrien - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Review in Pull Request Status Board Apr 14, 2019

@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Apr 14, 2019

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@armanio123 armanio123 merged commit a7ffc62 into DefinitelyTyped:master Apr 17, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Pull Request Status Board automation moved this from Review to Done Apr 17, 2019

@Kocal Kocal deleted the Kocal:feat/remove-rollup-plugin-node-resolve-types branch Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.