Skip to content

redux-saga-routines@3.0#34730

Merged
armanio123 merged 1 commit into
DefinitelyTyped:masterfrom
brainbeanapps:redux-saga-routines
Apr 15, 2019
Merged

redux-saga-routines@3.0#34730
armanio123 merged 1 commit into
DefinitelyTyped:masterfrom
brainbeanapps:redux-saga-routines

Conversation

@alexey-pelykh
Copy link
Copy Markdown
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • [] Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@alexey-pelykh alexey-pelykh force-pushed the redux-saga-routines branch 2 times, most recently from 1932d2e to 9b9c6af Compare April 14, 2019 15:34
@alexey-pelykh alexey-pelykh force-pushed the redux-saga-routines branch 4 times, most recently from e93fd2b to b1f1cee Compare April 14, 2019 15:53
@typescript-bot typescript-bot added the New Definition This PR creates a new definition package. label Apr 14, 2019
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 14, 2019

@alexey-pelykh Thank you for submitting this PR!

Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

@armanio123 armanio123 merged commit 3715c54 into DefinitelyTyped:master Apr 15, 2019
@typescript-bot
Copy link
Copy Markdown
Contributor

I just published @types/redux-saga-routines@3.0.0 to npm.

@alexey-pelykh alexey-pelykh deleted the redux-saga-routines branch April 16, 2019 04:44
@StanislavVoronov
Copy link
Copy Markdown

StanislavVoronov commented Apr 16, 2019

I have an error when createRoutine
const fetchMarket = createRoutine(NAMESPACE)
and when I write fetchMarket.request(), it requires for parameters, because of
export type Routine<
TTriggerActionCreator = ActionCreator

= TTriggerActionCreator & {
TRIGGER: string;
REQUEST: string;
SUCCESS: string;
FAILURE: string;
FULFILL: string;
} & {
trigger: TTriggerActionCreator;
request: ActionCreator, but it should be TTriggerActionCreator;
success: ActionCreator and here;
failure: ActionCreator and here;
fulfill: ActionCreator and here;
};

@alexey-pelykh
Copy link
Copy Markdown
Contributor Author

@StanislavVoronov addressed in #34760, yet it should not be TTriggerActionCreator, ActionCreator needs to be less strict

@StanislavVoronov
Copy link
Copy Markdown

@alexey-pelykh How to resolve this situation? Install version two?

@alexey-pelykh
Copy link
Copy Markdown
Contributor Author

@StanislavVoronov until fix is merged in day or two, you may just apply the change manually

@StanislavVoronov
Copy link
Copy Markdown

@alexey-pelykh thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Definition This PR creates a new definition package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants