[IMP] redux-saga-routines: support version 3.1#34760
Conversation
|
It appears that resolving typed of parameters (from 0 to 1-4 and to any number) does not work as expected. |
|
Same approach has been used in 2.x version |
|
@alexey-pelykh Thank you for submitting this PR! Because this PR doesn't have any code reviewers, a DefinitelyTyped maintainer will be reviewing it in the next few days once the Travis CI build passes. In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day! |
|
@alexey-pelykh The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
c6d1865 to
eb579b1
Compare
|
I apply this changes locally |
|
Typing is only applied in this way:
|
6f85fbf to
749fd54
Compare
|
Added some tests |
749fd54 to
03b8301
Compare
|
@alexey-pelykh maybe it should be strongly typed... |
|
@StanislavVoronov maybe it should, I've added possibility to type those methods, yet 100% declaration would be enormous |
|
@alexey-pelykh The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
e394255 to
011dcba
Compare
|
@StanislavVoronov I've added way to use typed |
c07392a to
6a56351
Compare
6a56351 to
17c3b88
Compare
17c3b88 to
7fb9d7e
Compare
|
I just published |
* [FIX] redux-saga-routines: loosen type definitions * [IMP] redux-saga-routines: support 3.1
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tslint.jsonshould be present, andtsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.If removing a declaration:
notNeededPackages.json.