Skip to content

[IMP] redux-storage: support v4.1.2#35197

Merged
weswigham merged 1 commit into
DefinitelyTyped:masterfrom
brainbeanapps:redux-storage
May 4, 2019
Merged

[IMP] redux-storage: support v4.1.2#35197
weswigham merged 1 commit into
DefinitelyTyped:masterfrom
brainbeanapps:redux-storage

Conversation

@alexey-pelykh

Copy link
Copy Markdown
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: react-stack/redux-storage@cbe9803
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@alexey-pelykh

Copy link
Copy Markdown
Contributor Author

Supersedes #34791

@typescript-bot

typescript-bot commented May 4, 2019

Copy link
Copy Markdown
Contributor

@alexey-pelykh Thank you for submitting this PR!

🔔 @asvetliakov @screendriver - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label May 4, 2019
@typescript-bot

Copy link
Copy Markdown
Contributor

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@weswigham weswigham merged commit 6897ae2 into DefinitelyTyped:master May 4, 2019
@typescript-bot

Copy link
Copy Markdown
Contributor

I just published @types/redux-storage@4.1.0 to npm.

@typescript-bot

Copy link
Copy Markdown
Contributor

I just published @types/redux-storage-engine-jsurl@1.0.2 to npm.

@typescript-bot

Copy link
Copy Markdown
Contributor

@alexey-pelykh alexey-pelykh deleted the redux-storage branch May 4, 2019 14:42
iRON5 pushed a commit to iRON5/DefinitelyTyped that referenced this pull request Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Unmerged The author did not merge the PR when it was ready.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants