Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix colornames default export type definition #35354
Please fill in this template.
Select one of these and delete the others:
If changing an existing definition:
The exported default function does not return a
I encountered this error when attempting to use the library in an existing typescript project using
In testing this change to the type definition, I did notice that using
But importing the library this way did:
The changes to the type definition in this PR work with both of the above examples.
manuth left a comment
This PR looks perfect to me.
Please consider to have a look at the comment I wrote during this review.