Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove loglevel, now that it includes its own types #35833

Closed

Conversation

Projects
None yet
2 participants
@pimterry
Copy link
Contributor

commented May 30, 2019

Types are included from v1.6.2 onwards: pimterry/loglevel@c54a06f


Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Follow the advice from the readme.
  • Avoid common mistakes.

Select one of these and delete the others:

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

Bonus changes:

  • Added a loglevel dependency to webpack-dev-middleware, which uses the loglevel types
  • Opened a PR to whitelist that dependency (this PR will fail to build until this is merged): microsoft/types-publisher#619
@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

@pimterry Thank you for submitting this PR!

🔔 @Pro @szmeti @screendriver @bumbleblym @reduckted @chrisabrams - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

@pimterry The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@pimterry

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

Failure is as expected - we'll need microsoft/types-publisher#619 merged before this will pass.

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

@pimterry I haven't seen anything from you in a while and this PR currently has problems that prevent it from being merged. The PR will be closed tomorrow if there aren't new commits to fix the issues.

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

@pimterry To keep things tidy, we have to close PRs that aren't mergeable but don't have activity from their author. No worries, though - please open a new PR if you'd like to continue with this change. Thank you!

Pull Request Status Board automation moved this from Needs Author Attention to Done Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.