Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

@types/chrome: Add chrome.declarativeContent.RequestContentScript #35951

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@bfred-it
Copy link

commented Jun 4, 2019

EDIT: someone teach the bot to wait for Draft PRs to became "Ready for review" 馃槄

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

@bfred-it Thank you for submitting this PR!

馃敂 @matthewkimber @otiai10 @couven92 @RReverser @sreimer15 @matcarlson @ekinsol - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

@bfred-it - It appears Travis did not correctly run on this PR! /cc @RyanCavanaugh to investigate and advise.

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

馃憢 Hi there! I鈥檝e run some quick performance metrics against master and your PR. This is still an experiment, so don鈥檛 panic if I say something crazy! I鈥檓 still learning how to interpret these metrics.

Let鈥檚 review the numbers, shall we?

Comparison details 馃搳
master #35951 diff
Batch compilation
Type count 27670 27675 0%
Assignability cache size 37309 37309 0%
Subtype cache size 113 113 0%
Identity cache size 16 16 0%
Language service
Samples taken 3030 3030 0%
Identifiers in tests 606 606 0%
getCompletionsAtPosition
聽聽聽聽Mean duration (ms) 749.8 753.6 +0.5%
聽聽聽聽Median duration (ms) 708.1 723.1 +2.1%
聽聽聽聽Std. deviation (ms) 138.8 122.3 -11.9%
聽聽聽聽Worst duration (ms) 1388.6 1429.8 +3.0%
聽聽聽聽Worst identifier append anchor
getQuickInfoAtPosition
聽聽聽聽Mean duration (ms) 720.7 698.6 -3.1%
聽聽聽聽Median duration (ms) 654.7 641.0 -2.1%
聽聽聽聽Std. deviation (ms) 163.0 163.8 +0.5%
聽聽聽聽Worst duration (ms) 1417.2 1461.6 +3.1%
聽聽聽聽Worst identifier append append

It looks like nothing changed too much. I鈥檓 pretty lenient since I鈥檓 still an experiment, so take a look anyways and make sure nothing looks out of place.


If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@couven92

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

@bfred-it thanks for the work! Ping us when you have finished, then I'll review :)

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2019

After 5 days, no one has reviewed the PR 馃槥. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@bfred-it

This comment has been minimized.

Copy link
Author

commented Jun 9, 2019

Closing for now

@bfred-it bfred-it closed this Jun 9, 2019

Pull Request Status Board automation moved this from Other to Done Jun 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.