Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove loglevel, now that it includes its own types #36403

Merged

Conversation

Projects
None yet
4 participants
@pimterry
Copy link
Contributor

commented Jun 24, 2019

Types are included from v1.6.2 onwards: pimterry/loglevel@c54a06f

This replaces the closed #35833 PR, now that the upstream PR is completed.


Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Follow the advice from the readme.
  • Avoid common mistakes.

Select one of these and delete the others:

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

Bonus changes:

  • Added a loglevel dependency to webpack-dev-middleware, which uses the loglevel types
  • Opened a PR to whitelist that dependency: microsoft/types-publisher#619 (already merged)
@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

Comparison details 📊
master #36403 diff
Batch compilation
Memory usage 73866648.0 68948416.0 -6.7%
Type count 10564 10565 0.0%
Assignability cache size 3102 3102 0.0%
Subtype cache size 60 60 0.0%
Identity cache size 1 1 0.0%
Language service
Samples taken 59 59 0.0%
Identifiers in tests 59 59 0.0%
getCompletionsAtPosition
    Mean duration (ms) 439.8 408.9 -7.0%
    Median duration (ms) 444.2 404.7 -8.9%
    Mean CV 14.0% 14.3% +2.5%
    Worst duration (ms) 528.7 469.3 -11.2%
    Worst identifier toJson console
getQuickInfoAtPosition
    Mean duration (ms) 430.1 418.7 -2.7%
    Median duration (ms) 423.3 417.6 -1.3%
    Mean CV 13.8% 15.2% +10.7%
    Worst duration (ms) 535.5 542.2 +1.3%
    Worst identifier toJson toJson
System information
Node version v10.15.3 v10.16.0
CPU count 2 2
CPU speed 2.294 GHz 2.294 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture x64 x64
Memory 6.8 GiB 6.8 GiB
Platform linux linux
Release 4.15.0-1041-azure 4.15.0-1046-azure

First off, note that the system varied slightly between these two runs, so you’ll have to take these measurements with a grain of salt.

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.


If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

@pimterry Thank you for submitting this PR!

🔔 @Pro @szmeti @screendriver @bumbleblym @reduckted @chrisabrams - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@screendriver
Copy link
Contributor

left a comment

LGTM 👍

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Check and Merge in Pull Request Status Board Jun 24, 2019

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@DanielRosenwasser DanielRosenwasser merged commit b231fe9 into DefinitelyTyped:master Jun 24, 2019

3 checks passed

DefinitelyTyped.BenchmarkPR Build #6667 succeeded
Details
DefinitelyTyped.DefinitelyTyped Build #20190624.28 succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Pull Request Status Board automation moved this from Check and Merge to Done Jun 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.