Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox-webext-browser: Change return type of browser.permissions.remove #36655

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@bfred-it
Copy link

commented Jul 4, 2019

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@bfred-it

This comment has been minimized.

Copy link
Author

commented Jul 4, 2019

Closing because this is a generated file.

@bfred-it bfred-it closed this Jul 4, 2019

@bfred-it bfred-it deleted the bfred-it:patch-2 branch Jul 4, 2019

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2019

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

Comparison details 📊
master #36655 diff
Batch compilation
Memory usage (MiB) 82.5 73.5 -10.9%
Type count 11618 11618 0.0%
Assignability cache size 33997 33997 0.0%
Subtype cache size 0 0
Identity cache size 3 3 0.0%
Language service
Samples taken 102 102 0.0%
Identifiers in tests 102 102 0.0%
getCompletionsAtPosition
    Mean duration (ms) 447.5 445.6 -0.4%
    Median duration (ms) 445.2 438.1 -1.6%
    Mean CV 13.8% 13.5% -2.5%
    Worst duration (ms) 580.1 592.6 +2.1%
    Worst identifier console proxy
getQuickInfoAtPosition
    Mean duration (ms) 426.1 429.7 +0.9%
    Median duration (ms) 417.3 424.0 +1.6%
    Mean CV 14.5% 13.7% -5.5%
    Worst duration (ms) 595.2 534.8 -10.2%
    Worst identifier console onRequest

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.


If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.